gh-102491: Remove IronPython version check in sys_version#102492
gh-102491: Remove IronPython version check in sys_version#102492hauntsaninja merged 8 commits intopython:mainfrom
Conversation
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks, this looks good. Would you mind adding the news entry?
hauntsaninja
left a comment
There was a problem hiding this comment.
Hm, not an issue with this PR, but I was curious what IronPython is doing. It looks like their platform.py has https://github.com/IronLanguages/ironpython3/blob/f41afc44534786721b89e1efb8e50c4232ee1224/Src/StdLib/Lib/platform.py#L1141 and https://github.com/IronLanguages/ironpython3/blob/f41afc44534786721b89e1efb8e50c4232ee1224/Src/StdLib/Lib/platform.py#L1187
Weirdly, IronPython's docs indicates that its sys.version would not match the regex we have or the regex they have in their platform.py.
@hauntsaninja Good point. I created an issue IronLanguages/ironpython3#1667. Based on the decision there, can you (as core dev) make a decision on the other ironpython regular expression. |
The platform module contains various version checks for systems such as cpython and ironpython. The file also contains a specfic case for ironpython which can be removed (see IronLanguages/ironpython3#1667)
Removing the check improves the import speed as it avoids the compilation of a two regular expressions.
Note: most of the compiled regular expressions in
platform.pycan be moved into the methods using them, as most results are cached. This would reduce the importtime forplatformeven further: